[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: '#define inline' patch for Bison on Compaq/DEC Alpha OSF/1 4.0
From: |
Akim Demaille |
Subject: |
Re: '#define inline' patch for Bison on Compaq/DEC Alpha OSF/1 4.0 |
Date: |
13 Nov 2002 10:43:42 +0100 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Honest Recruiter) |
| I installed the following patch into Bison. Having the #define inline
| depend only on __GNUC__ is wrong, since many other compilers support
| "inline" (C99 requires it).
|
| 2002-11-12 Paul Eggert <address@hidden>
|
| * data/glr.c (inline): Remove #define. It's the user's
| responsibility to #define it away, just like 'const'.
| This fixes one of the bugs reported by Nelson H.F. Beebe in
| <http://mail.gnu.org/pipermail/bug-bison/2002-November/001873.html>.
|
| Index: data/glr.c
| ===================================================================
| RCS file: /cvsroot/bison/bison/data/glr.c,v
| retrieving revision 1.33
| diff -p -u -r1.33 glr.c
| --- data/glr.c 12 Nov 2002 09:03:12 -0000 1.33
| +++ data/glr.c 13 Nov 2002 06:24:14 -0000
| @@ -243,10 +243,6 @@ b4_syncline(address@hidden@], address@hidden@])
| # define ATTRIBUTE_UNUSED __attribute__ ((__unused__))
| #endif
|
| -#if ! defined (__GNUC__)
| -# define inline
| -#endif
| -
| /* YYFINAL -- State number of the termination state. */
| #define YYFINAL ]b4_final_state_number[
| /* YYLAST -- Last index in YYTABLE. */
Hi Paul,
But then, we are releasing glr.c for C((, not C89 extended, as was
intended. How about
#if ! defined (__GNUC__) && ! defined inline
# define inline
#endif
instead?