Re: Missing include library, or misplaced header: stdbool.h

[Paul Eggert]

Paul Hilfinger <address@hidden> writes:

> When stdbool.h has to be generated, it is placed in
> BUILD-DIRECTORY/lib, but that directory is not in the include path in
> src or lib.  The following patch would fix the problem, but I don't
> know what was really intended, and I don't quite see how this problem
> could have slipped by, so perhaps *I* am missing something.  

No, you've caught a real problem.  Thanks.  Sorry, I don't usually
test builds outside of the source directory; I suppose I should.

The Automake documentation says INCLUDES is obsolescent; you're
supposed to use AM_CPPFLAGS now.  This feature worked in Automake 1.4
(dated January 1999), so I think it's safe to assume for Bison.
Also, most of the INCLUDES stuff is deduced automatically nowadays.
So I installed the following patch.

2004-02-02  Paul Eggert  <address@hidden>

        * src/Makefile.am (AM_CPPFLAGS): New macro.  It mentions
        $(top_srcdir)/lib and ../lib.  This fixes a bug reported
        by Paul Hilfinger; the old INCLUDES value didn't mention ../lib.
        There's no need to mention top_builddir since Automake does that
        for us.
        (INCLUDES): Remove, as Automake says it's obsolescent.
        Contents migrated into AM_CPPFLAGS as described above.
        * lib/Makefile.am (INCLUDES): Remove; obsolescent.

Index: lib/Makefile.am
===================================================================
RCS file: /cvsroot/bison/bison/lib/Makefile.am,v
retrieving revision 1.41
diff -p -u -r1.41 Makefile.am
--- lib/Makefile.am     17 Jun 2003 07:16:05 -0000      1.41
+++ lib/Makefile.am     2 Feb 2004 22:31:19 -0000
@@ -1,4 +1,4 @@
-## Copyright (C) 2001, 2002, 2003 Free Software Foundation, Inc.
+## Copyright (C) 2001, 2002, 2003, 2004 Free Software Foundation, Inc.
 
 ## This program is free software; you can redistribute it and/or modify
 ## it under the terms of the GNU General Public License as published by
@@ -20,11 +20,6 @@ AM_CFLAGS = $(WARNING_CFLAGS)
 lib_LIBRARIES = $(YACC_LIBRARY)
 EXTRA_LIBRARIES = liby.a
 noinst_LIBRARIES = libbison.a
-
-# config.h is in build/., and system.h is in src/src/.
-INCLUDES = -I$(top_builddir)      \
-           -I$(top_srcdir)/src \
-           -I$(top_srcdir)/lib
 
 liby_a_SOURCES = main.c yyerror.c
 
Index: src/Makefile.am
===================================================================
RCS file: /cvsroot/bison/bison/src/Makefile.am,v
retrieving revision 1.62
diff -p -u -r1.62 Makefile.am
--- src/Makefile.am     25 Aug 2003 15:16:24 -0000      1.62
+++ src/Makefile.am     2 Feb 2004 22:31:40 -0000
@@ -1,4 +1,4 @@
-## Copyright (C) 2001, 2002, 2003 Free Software Foundation, Inc.
+## Copyright (C) 2001, 2002, 2003, 2004 Free Software Foundation, Inc.
 
 ## This program is free software; you can redistribute it and/or modify
 ## it under the terms of the GNU General Public License as published by
@@ -20,11 +20,8 @@ DEFS = @DEFS@ \
   -DLOCALEDIR=\"$(datadir)/locale\"
 
 AM_CFLAGS = $(WARNING_CFLAGS) $(WERROR_CFLAGS)
+AM_CPPFLAGS = -I$(top_srcdir)/lib -I../lib
 AM_YFLAGS = "-dv"
-
-# config.h is in build/.
-INCLUDES = -I$(top_builddir)      \
-           -I$(top_srcdir)/lib
 
 LDADD = ../lib/libbison.a $(LIBINTL)