bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: glr: include the created header


From: Akim Demaille
Subject: Re: glr: include the created header
Date: Sat, 3 Dec 2005 13:49:57 +0100


Le 3 déc. 05 à 02:44, Joel E. Denny a écrit :

On Sat, 12 Nov 2005, Akim Demaille wrote:

It makes my life significantly easier, and avoids code
duplication, if glr.c could include its header file instead
of open coding the declarations of the tokens, stype and ltype.
It will also make it easier to export declarations such as
yyparse's.

Did you intend for b4_pre_prologue to appear in b4_shared_declarations? I didn't expect to see my prologues in my header file. This can lead to unexpected pollution of the namespace of the #includer, and it's inconsistent with yacc.c at least.

Yes I did, because the pre-prologue is expected to define what
yystype needs, and the latter is export in the header file.  Actually,
that's something I wish I could also change in yacc.c...

If you don't want them to be exported, they should probably be
in the post-prologue.  Is that ok with you?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]