Re: %destructor feedback

[Paul Eggert]

Akim Demaille <address@hidden> writes:

> I installed the following.  Note that the warning is somewhat annoying
> with rules running YYERROR etc.

Thanks.  One minor thing: there's no need to include forward static
decls when the functions are defined before used, and the usual style
in Bison is to omit them.  I installed the following.

2005-12-27  Paul Eggert  <address@hidden>

        * src/reader.c (grammar_midrule_action, grammar_symbol_append):
        Remove unnecessary forward static decls.

--- reader.c.~1.242.~   2005-12-27 09:50:00.000000000 -0800
+++ reader.c    2005-12-27 11:47:19.000000000 -0800
@@ -36,9 +36,6 @@
 #include "symlist.h"
 #include "symtab.h"
 
-static void grammar_midrule_action (void);
-static void grammar_symbol_append (symbol *sym, location loc);
-
 static symbol_list *grammar = NULL;
 static bool start_flag = false;
 merger_list *merge_functions;
@@ -168,7 +165,7 @@ grammar_symbol_append (symbol *sym, loca
 
   grammar_end = p;
 
-  /* SYM = 0 stands for an end of rule, it is not an actual
+  /* A null SYM stands for an end of rule; it is not an actual
      part of it.  */
   if (sym)
     ++nritems;
@@ -247,7 +244,7 @@ grammar_rule_check (const symbol_list *r
        warn_at (r->location,
                 _("empty rule for typed nonterminal, and no action"));
     }
-  
+
   /* Check that typed symbol values are used.  */
   {
     symbol_list *l = r;