Re: bison ps f

[Paul Eggert]

twlevo <address@hidden> writes:

> looks like the tabs in maintainer-check-valgrind in tests/Makefile.am
> are a problem when running `ps f' which does translate those tabs into
> ???, at least with procps version 3.2.3 . 
>
> can you change that into spaces instead of tabs?

Yes, if I understand you correctly.  I installed the patch below.

> also GLR is not mentioned on the homepage of Bison
> and GLR nowadays is going every day better and better. 

That's a documentation fix, I guess.  Suggestions, anybody?

2006-03-06  Paul Eggert  <address@hidden>

        * tests/Makefile.am ($(srcdir)/package.m4, maintainer-check-valgrind):
        Don't use tabs inside commands; it messes up 'ps'.
        Problem reported by twlevo.

--- tests/Makefile.am   24 Jul 2005 07:24:22 -0000      1.41
+++ tests/Makefile.am   6 Mar 2006 08:29:22 -0000       1.42
@@ -2,7 +2,7 @@
 
 ## Makefile for Bison testsuite.
 
-## Copyright (C) 2000, 2001, 2002, 2003, 2004, 2005 Free Software
+## Copyright (C) 2000, 2001, 2002, 2003, 2004, 2005, 2006 Free Software
 ## Foundation, Inc.
 
 ## This program is free software; you can redistribute it and/or modify
@@ -30,7 +30,7 @@ MAINTAINERCLEANFILES = Makefile.in $(TES
 ## ------------ ##
 
 $(srcdir)/package.m4: $(top_srcdir)/configure.ac
-       {                                       \
+       { \
          echo '# Signature of the current package.'; \
          echo 'm4_define([AT_PACKAGE_NAME],      [$(PACKAGE_NAME)])'; \
          echo 'm4_define([AT_PACKAGE_TARNAME],   [$(PACKAGE_TARNAME)])'; \
@@ -87,11 +87,8 @@ maintainer-check-posix: $(TESTSUITE)
 
 .PHONY: maintainer-check-valgrind
 maintainer-check-valgrind: $(TESTSUITE)
-       if test -n "$(VALGRIND)"; then                                      \
-          $(TESTSUITE) PREBISON='$(VALGRIND) -q' PREPARSER='$(VALGRIND) -q'; \
-       else                                                                \
-         true;                                                             \
-       fi
+       test -z '$(VALGRIND)' || \
+          $(TESTSUITE) PREBISON='$(VALGRIND) -q' PREPARSER='$(VALGRIND) -q'
 
 .PHONY: maintainer-check
 maintainer-check: maintainer-check-posix maintainer-check-valgrind 
maintainer-check-g++