Re: [PATCH] Add EXEEXT to doc/local.mk

[Akim Demaille]

Le 16 nov. 08 à 03:04, Di-an JAN a écrit :

Hi Di-an,

> Instead of the minimal change of adding $(EXEEXT), I made src/bison
> a real prerequisite since it's in the same Makefile now.
>
> Tested on Cygwin with `touch src/getargs.c; make' and spot checking
> with info and pdf.

This is technically correct, but you make this a user-time  
dependency.  The fake dependency in the code is tailored so that we  
don't require the user to have makeinfo on her side to generate the  
info files.  So the fix is really to add $(EXEEXT), which I did.

Thanks!

From 23ce6f4cb35ec3b966d01f9236196665e58e3dd6 Mon Sep 17 00:00:00 2001
From: Akim Demaille <address@hidden>
Date: Sun, 16 Nov 2008 19:49:35 +0100
Subject: [PATCH] Add missing $(EXEEXT).

        * doc/local.mk ($(CROSS_OPTIONS_TEXI)): The target is
        "src/bison$(EXEEXT)".
        Reported by Di-an Jan.
---
 ChangeLog    |    7 +++++++
 doc/local.mk |    3 +--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 5cb6b0d..2b31a12 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-11-16  Akim Demaille  <address@hidden>
+
+       Add missing $(EXEEXT).
+       * doc/local.mk ($(CROSS_OPTIONS_TEXI)): The target is
+       "src/bison$(EXEEXT)".
+       Reported by Di-an Jan.
+
 2008-11-15  Akim Demaille  <address@hidden>

        * TODO: Update.
diff --git a/doc/local.mk b/doc/local.mk
index 15a232f..d54952f 100644
--- a/doc/local.mk
+++ b/doc/local.mk
@@ -1,4 +1,3 @@
-## Process this file with automake to produce Makefile.in -*-Makefile- 
*-
 ## Copyright (C) 2001, 2002, 2003, 2005, 2006, 2007, 2008 Free  
Software
 ## Foundation, Inc.

@@ -31,7 +30,7 @@ CROSS_OPTIONS_PL = $(top_srcdir)/build-aux/cross- 
options.pl
 CROSS_OPTIONS_TEXI = $(top_srcdir)/doc/cross-options.texi
 $(CROSS_OPTIONS_TEXI): $(top_srcdir)/src/getargs.c $(CROSS_OPTIONS_PL)
        -rm -f $@ address@hidden
-       $(MAKE) $(AM_MAKEFLAGS) src/bison
+       $(MAKE) $(AM_MAKEFLAGS) src/bison$(EXEEXT)
        $(top_builddir)/src/bison --help | perl $(CROSS_OPTIONS_PL) 
>address@hidden
        mv address@hidden $@
 MAINTAINERCLEANFILES = $(CROSS_OPTIONS_TEXI)
--
1.6.0.2.588.g3102