Re: [PATCH] Use AT_DATA_GRAMMAR for C++ compile test for variants

[Di-an JAN]

On Mon, 17 Nov 2008, Paolo Bonzini wrote:

> Akim Demaille wrote:
> > > > > "PB" == Paolo Bonzini <address@hidden> writes:
> >
> > > Akim Demaille wrote:
> > >>
> > >> Le 17 nov. 08 à 01:42, Di-an JAN a écrit :
> > >>
> > >>> This patch uses AT_DATA_GRAMMAR instead of AT_DATA for C++ compiled tests
> > >>> as requested by the comments to AT_DATA_GRAMMAR_PROLOGUE in
> > >>> tests/local.at.
> >
> > > I'm still having failures of 199 202 209 210 here...
> >
> > Could you please send logs?  I don't have any failure.
>
> Here they are, powerpc-apple-darwin8.11.0.

You seem to have more tests than me.  Your ``199 202 209 210'' are my
``189 192 205 206''.  My ``tests/testsuite -l'' is attached.
Anyway, your first two failures seem to indicate you didn't get part of:

commit 2ea7730c5640c6a987dce6907363e96fc65c071b
Author: Akim Demaille <address@hidden>
Date:   Mon Aug 25 13:52:51 2008 +0200

    Locations are no longer required by lalr1.cc.

        * data/lalr1.cc (_b4_args, b4_args): New.
        Adjust all uses of locations to make them optional.
        * tests/c++.at (AT_CHECK_VARIANTS): No longer use the locations.
        (AT_CHECK_NAMESPACE): Check the use of locations.
        * tests/calc.at (_AT_DATA_CALC_Y): Adjust to be usable with or
        without locations with lalr1.cc.
        Test these cases.
        * tests/output.at: Check lalr1.cc with and without location
        support.
        * tests/regression.at (_AT_DATA_EXPECT2_Y, _AT_DATA_DANCER_Y):
        Don't use locations.

Di-an Jan

#                             -*- compilation -*-
199. regression.at:956: testing ...
../../tests/regression.at:956: bison -o dancer.c dancer.y
../../tests/regression.at:956: bison -o dancer.cc dancer.y
../../tests/regression.at:956: $BISON_CXX_WORKS
stderr:
stdout:
../../tests/regression.at:956: $CXX $CXXFLAGS $CPPFLAGS $LDFLAGS -o dancer 
dancer.cc $LIBS
stderr:
dancer.y:59: error: expected ',' or '...' before '&' token
dancer.y:59: error: ISO C++ forbids declaration of 'location' with no type
dancer.y:59: error: prototype for 'void yy::parser::error(int)' does not match 
any in class 'yy::parser'
dancer.hh:147: error: candidate is: virtual void yy::parser::error(const 
std::string&)
dancer.y: In member function 'void yy::parser::error(int)':
dancer.y:61: error: 'm' was not declared in this scope
stdout:
../../tests/regression.at:956: exit code was 1, expected 0
199. regression.at:956: 199. Dancer %skeleton "lalr1.cc" (regression.at:956): 
FAILED (regression.at:956)
#                             -*- compilation -*-
202. regression.at:1056: testing ...
../../tests/regression.at:1056: bison -o expect2.c expect2.y
../../tests/regression.at:1056: bison -o expect2.cc expect2.y
../../tests/regression.at:1056: $BISON_CXX_WORKS
stderr:
stdout:
../../tests/regression.at:1056: $CXX $CXXFLAGS $CPPFLAGS $LDFLAGS -o expect2 
expect2.cc $LIBS
stderr:
expect2.y:30: error: expected ',' or '...' before '&' token
expect2.y:30: error: ISO C++ forbids declaration of 'location' with no type
expect2.y:30: error: prototype for 'void yy::parser::error(int)' does not match 
any in class 'yy::parser'
expect2.hh:144: error: candidate is: virtual void yy::parser::error(const 
std::string&)
expect2.y: In member function 'void yy::parser::error(int)':
expect2.y:32: error: 'm' was not declared in this scope
stdout:
../../tests/regression.at:1056: exit code was 1, expected 0
202. regression.at:1056: 202. Expecting two tokens %skeleton "lalr1.cc" 
(regression.at:1056): FAILED (regression.at:1056)

testsuite-l.txt
Description: Text document