[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] --warnings=no-XXX [RFC] --warnings categories
From: |
Di-an JAN |
Subject: |
Re: [PATCH] --warnings=no-XXX [RFC] --warnings categories |
Date: |
Fri, 21 Nov 2008 20:13:29 -0800 (PST) |
On Fri, 21 Nov 2008, Akim Demaille wrote:
Di-an, could you please push in master the patch of yours that warns about
the missing ; and adds them? We can have it in 2.5 to drop the ; feature
completely starting with 2.6 or so.
Do you want to keep the warning forever or just for 2.5?
Should it be just for default language, default skeleton, and --yacc?
It should work for C, C++, and Java.
Thinking about it some more, I agree with Joel[2] that this patch[1] is
too complicated to be worthwhile. I mean, trying to handle preprocessing
directives... I didn't even thought about it until the testsuite failed.
Bison really shouldn't do the job of the compiler, whenever possible[3].
I think we can do without the warning as there will be a compiler
error whenever the warning issued correctly.
The only reason to bother is for bug-compatibility, and the reported
problem[4] is GCC's sample frontend treelang, which is not supposed to
be actually used, and is removed from GCC 4.4 (in development)[5].
Di-an Jan
[1] The patch:
http://lists.gnu.org/archive/html/bison-patches/2008-11/msg00104.html
[2] Joel's response:
http://lists.gnu.org/archive/html/bison-patches/2008-11/msg00105.html
[3] The %parse-param and %lex-param code in src/parse-gram.y wouldn't
work for say Pascal, and even for C it fails for
%parse-param {int func(int)}
or even
%parse-param {int x /* The parser parameter. */}
[4] The original bug report:
http://lists.gnu.org/archive/html/bug-bison/2008-11/msg00001.html
[5] Treelang removed from GCC:
http://gcc.gnu.org/ml/gcc-patches/2008-03/msg00380.html
http://gcc.gnu.org/ml/gcc-patches/2008-03/msg00420.html
http://gcc.gnu.org/viewcvs?view=rev&revision=132976