bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

testsuite: work around autoconf 2.63b bug


From: Eric Blake
Subject: testsuite: work around autoconf 2.63b bug
Date: Tue, 7 Apr 2009 04:10:33 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

I noticed this started failing when I upgraded autoconf to the recently-
released beta 2.63b:

$ dbgmake check TESTSUITEFLAGS='-k \#'

The bug (actually, two related bugs) has since been fixed in autoconf, per this 
thread: http://lists.gnu.org/archive/html/autoconf-patches/2009-04/msg00002.html

But since others may be bit by this, would you like me to apply this patch to 
all the active branches to avoid tickling the bug in the first place?  The idea 
is to use a quadrigraph instead of an active m4 character to make sure the 
testsuite is emitted correctly; the resulting testsuite tests the same #.c file 
name as before.

Is branch-2.4.2 still active?

Do you prefer me applying topic branches and then merging up from oldest to 
newest (how automake.git and git.git behave), or just linear history with 
cherry-picking (how findutils.git and m4.git have been behaving)?  gnulib.git 
also uses linear history, but unless you have multiple active branches, the 
question is moot.  I kind of like the idea of merging topic branches.


From: Eric Blake <address@hidden>
Date: Mon, 6 Apr 2009 22:05:38 -0600
Subject: [PATCH] Work around autoconf 2.63b bug in testsuite.

* tests/output.at (AT_CHECK_OUTPUT_FILE_NAME): Avoid tripping
autoconf bug related to # in test.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog       |    6 ++++++
 tests/output.at |    6 +++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 7614645..aa13e01 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-04-06  Eric Blake  <address@hidden>
+
+       Work around autoconf 2.63b bug in testsuite.
+       * tests/output.at (AT_CHECK_OUTPUT_FILE_NAME): Avoid tripping
+       autoconf bug related to # in test.
+
 2009-04-06  Joel E. Denny  <address@hidden>

        * NEWS (2.5): New section.  Describe new -D/--define feature.
diff --git a/tests/output.at b/tests/output.at
index fe5708c..971df1e 100644
--- a/tests/output.at
+++ b/tests/output.at
@@ -1,6 +1,6 @@
 # Checking the output filenames.                    -*- Autotest -*-
-# Copyright (C) 2000, 2001, 2002, 2005, 2006, 2007, 2008 Free Software
-# Foundation, Inc.
+# Copyright (C) 2000, 2001, 2002, 2005, 2006, 2007, 2008, 2009 Free
+# Software Foundation, Inc.

 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -214,7 +214,7 @@ m4_define([_m4_expand],
 [m4_changequote([-=<{(], [)}>=-])$1m4_changequote([, ])])])
 AT_CHECK_OUTPUT_FILE_NAME([[(]])
 AT_CHECK_OUTPUT_FILE_NAME([[)]])
-AT_CHECK_OUTPUT_FILE_NAME([[#]])
+AT_CHECK_OUTPUT_FILE_NAME(address@hidden:@]])
 AT_CHECK_OUTPUT_FILE_NAME([[@@]])
 AT_CHECK_OUTPUT_FILE_NAME(address@hidden)
 AT_CHECK_OUTPUT_FILE_NAME(address@hidden)
-- 
1.6.1.2







reply via email to

[Prev in Thread] Current Thread [Next in Thread]