Re: FYI: master: address some of the syntax-check errors

[Stefano Lattarini]

Hi Akim.  Few random observations from an outsider ...

On 02/18/2012 07:32 PM, Akim Demaille wrote:
> This is perfectly uninteresting work.  It's good that
> it's done though.  Will import to 2.5 too.
> 
>
> --- a/lib/bitset_stats.c
> +++ b/lib/bitset_stats.c
> -        perror (_("Could not write stats file."));
> +        perror (_("cannot not write stats file"));
>
"cannot not"?  A simple "cannot" would sound better ;-)

Ditto for other similar changes.

> --- a/etc/bench.pl.in
> +++ b/etc/bench.pl.in
> @@ -528,9 +528,8 @@ yylex (void)
>  static int
>  power (int base, int exponent)
> {
> +  assert (0 <= exponent);
>   int res = 1;
> -  if (exponent < 0)
> -    exit (3);
>   for (/* Niente */; exponent; --exponent)
>
Unrelated to this patch, but it has caught my eye anyway ...  why this
comment in italian ("Niente") here?

Regards,
  Stefano