[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: RFC: [PATCH] maint: use xconcatenated_filename
|
From: |
Paul Eggert |
|
Subject: |
Re: RFC: [PATCH] maint: use xconcatenated_filename |
|
Date: |
Tue, 05 Jun 2012 08:55:54 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 06/05/2012 08:37 AM, Akim Demaille wrote:
> + bool use_push_for_pull_flag = cp && *cp && STRNEQ (cp, "0");
A nit: shouldn't that 'STRNEQ (cp, "0")' be
'strtol (cp, 0, 10) != 0'? That would recognize,
e.g., "00" as zero. No big deal either way.