bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] warnings: used but undeclared symbols are warnings


From: Akim Demaille
Subject: Re: [PATCH] warnings: used but undeclared symbols are warnings
Date: Wed, 20 Jun 2012 22:10:22 +0200

Le 20 juin 2012 à 11:09, Akim Demaille a écrit :

> Also, and much worse, your patches "degrades" serious errors into
> simple warnings.  This is not acceptable, and unfortunately, this
> is not caught by the test suite.  Please, take the following example,
> and make it a test.
> 
> $ cat /tmp/foo.y
> %printer {} foo;
> %%
> exp: 'a';

Sorry, that was 'exp: "foo"'.

> $ LC_ALL=C bison /tmp/foo.y
> /tmp/foo.y:1.13-15: symbol foo is used, but is not defined as a token and has 
> no rules
> 
> $ LC_ALL=C ./_build/debug7/tests/bison /tmp/foo.y
> /tmp/foo.y:1.13-15: warning: symbol foo is used, but is not defined as a 
> token and has no rules
> /tmp/foo.y: warning: 3 nonterminals useless in grammar
> /tmp/foo.y: warning: 2 rules useless in grammar
> /tmp/foo.y:3.1-3: fatal error: start symbol exp does not derive any sentence
> 
> I should have tested more thoroughly before pushing, sorry.  Waiting
> for your fix.

Here is my proposal.

Attachment: 0001-fix-warnings-for-useless-printer-destructor.patch
Description: Binary data



reply via email to

[Prev in Thread] Current Thread [Next in Thread]