bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] {master} Associativity warning


From: Akim Demaille
Subject: Re: [PATCH 0/2] {master} Associativity warning
Date: Wed, 30 Jan 2013 10:29:44 +0100

hi Valentin,

Le 29 janv. 2013 à 16:27, Valentin Tolmer <address@hidden> a écrit :

> Bison now warns when a defined associativity is useless. It is important to
> remove these warnings, because that will reveal the useless priorities as
> well, with the corresponding warning.  The tokens mentioned should be
> declared with %precedence (it will not change the parsing tables).
> 
> Valentin Tolmer (2):
>  parsing: record used associativity and print useless ones
>  tests: New associativity warning test, and testsuite sanitizing

Great job, thanks.  I have squashed them together, since the
first patch breaks the test suite, which is fixed by your
second one.  I prefer to keep the test suite green at each
commit.

Also, I have fixed your used of the past tense instead of the
imperative in the commit message.

Pushed to master.

For you next contribution, I'd like you to prepare a complete
section (starting with **) in NEWS about all your work (described
as several *** items).  Including the introduction of -Wprecedence.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]