[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
style: sort includes and avoid assignments
From: |
Akim Demaille |
Subject: |
style: sort includes and avoid assignments |
Date: |
Wed, 30 Jan 2019 07:08:38 +0100 |
commit 32b9dcecc75e8510c3f7beda0b060e96b31f1b1f
Author: Akim Demaille <address@hidden>
Date: Tue Jan 29 23:04:00 2019 +0100
style: sort includes and avoid assignments
* src/symtab.c: Sort includes.
* src/gram.c (grammar_rules_print_xml): Avoid assignments to define
'usefulness'.
diff --git a/src/gram.c b/src/gram.c
index 19c588d6..2f094944 100644
--- a/src/gram.c
+++ b/src/gram.c
@@ -218,13 +218,10 @@ grammar_rules_print_xml (FILE *out, int level)
xml_puts (out, level + 1, "<rules>");
first = false;
{
- char const *usefulness;
- if (rule_useless_in_grammar_p (&rules[r]))
- usefulness = "useless-in-grammar";
- else if (rule_useless_in_parser_p (&rules[r]))
- usefulness = "useless-in-parser";
- else
- usefulness = "useful";
+ char const *usefulness
+ = rule_useless_in_grammar_p (&rules[r]) ? "useless-in-grammar"
+ : rule_useless_in_parser_p (&rules[r]) ? "useless-in-parser"
+ : "useful";
xml_indent (out, level + 2);
fprintf (out, "<rule number=\"%d\" usefulness=\"%s\"",
rules[r].number, usefulness);
diff --git a/src/symtab.c b/src/symtab.c
index b9a934f7..0941d2b5 100644
--- a/src/symtab.c
+++ b/src/symtab.c
@@ -19,13 +19,14 @@
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include <config.h>
+#include "symtab.h"
+
#include "system.h"
#include <hash.h>
#include "complain.h"
#include "gram.h"
-#include "symtab.h"
/*-------------------------------------------------------------------.
| Symbols sorted by tag. Allocated by the first invocation of |
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- style: sort includes and avoid assignments,
Akim Demaille <=