bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

glr: remove useless casts


From: Akim Demaille
Subject: glr: remove useless casts
Date: Sat, 30 Nov 2019 16:41:01 +0100

Prompted by Frank's report 
(https://lists.gnu.org/archive/html/bug-bison/2019-11/msg00016.html).  I never 
understood why we had these casts, and GCC agrees.

commit 24c5214ae840b1b3b5f98a29d5967779cc9a5b5a
Author: Akim Demaille <address@hidden>
Date:   Sat Nov 30 13:24:14 2019 +0100

    glr: remove useless casts
    
    Reported by GCC's -Wuseless-cast.
    
    * data/skeletons/glr.c: Don't cast to yybool, it's useless.

diff --git a/data/skeletons/glr.c b/data/skeletons/glr.c
index 8603d51f..f1f3715f 100644
--- a/data/skeletons/glr.c
+++ b/data/skeletons/glr.c
@@ -846,8 +846,7 @@ yyuserAction (yyRuleNum yyn, int yyrhslen, yyGLRStackItem* 
yyvsp,
               yyGLRStack* yystackp,
               YYSTYPE* yyvalp]b4_locuser_formals[)
 {
-  yybool yynormal YY_ATTRIBUTE_UNUSED
-    = YY_CAST (yybool, yystackp->yysplitPoint == YY_NULLPTR);
+  yybool yynormal YY_ATTRIBUTE_UNUSED = yystackp->yysplitPoint == YY_NULLPTR;
   int yylow;
 ]b4_parse_param_use([yyvalp], [yylocp])dnl
 [  YYUSE (yyrhslen);
@@ -982,7 +981,7 @@ yylhsNonterm (yyRuleNum yyrule)
 static inline yybool
 yyisDefaultedState (yyStateNum yystate)
 {
-  return YY_CAST (yybool, yypact_value_is_default (yypact[yystate]));
+  return yypact_value_is_default (yypact[yystate]);
 }
 
 /** The default reduction for YYSTATE, assuming it has one.  */
@@ -1042,13 +1041,13 @@ yyLRgotoState (yyStateNum yystate, yySymbol yysym)
 static inline yybool
 yyisShiftAction (int yyaction)
 {
-  return YY_CAST (yybool, 0 < yyaction);
+  return 0 < yyaction;
 }
 
 static inline yybool
 yyisErrorAction (int yyaction)
 {
-  return YY_CAST (yybool, yyaction == 0);
+  return yyaction == 0;
 }
 
                                 /* GLRStates */
@@ -2406,7 +2405,7 @@ b4_dollar_popdef])[]dnl
           ptrdiff_t yys;
 
           for (yys = 0; yys < yystack.yytops.yysize; yys += 1)
-            yystackp->yytops.yylookaheadNeeds[yys] = YY_CAST (yybool, yychar 
!= YYEMPTY);
+            yystackp->yytops.yylookaheadNeeds[yys] = yychar != YYEMPTY;
 
           /* yyprocessOneStack returns one of three things:
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]