[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] Add command line option to map file prefixes
From: |
Joshua Watt |
Subject: |
Re: [PATCH v3] Add command line option to map file prefixes |
Date: |
Tue, 12 May 2020 11:33:45 -0500 |
On Tue, May 12, 2020, 11:29 AM Akim Demaille <address@hidden> wrote:
> Hi Joshua,
>
> > Le 12 mai 2020 à 14:09, Joshua Watt <address@hidden> a écrit :
> >
> > On Mon, May 11, 2020, 11:31 PM Akim Demaille <address@hidden> wrote:
> >
> >> This gives the impression that it's ok not to have an argument, but the
> >> argument is (fortunately) mandatory. You should remove the if.
> >>
> >
> > Ah right. I missed that one. Probably should have a test too
> >
> >
> >> And, FTR (and then again, I can do it, I don't know if you forgot about
> >> it, or meant not to do it), doc/bison.texi needs to be updated.
> >>
> >
> > I just forgot to do it.
> >
> > I won't have time to do them until tomorrow, so if you want to fix up the
> > last few minor things and push the change, that's fine with me.
>
> I'm not allowed to install anything from you until the FSF's copyright
> clerk tells me he has all the needed paperwork, so we're not in a hurry.
>
That's fine. I sent the email a few days ago and wasn't sure how long it
would take.
Thanks
> Thanks!