[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Argument quoting problem when processing config_subdirs
From: |
Akim Demaille |
Subject: |
Re: Argument quoting problem when processing config_subdirs |
Date: |
17 Jan 2001 09:40:15 +0100 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Crater Lake) |
>>>>> "Tim" == Tim Van Holder <address@hidden> writes:
Please, don't make private answers about Autoconf.
>> Sorry, please ignore my previous message, it was really stupid.
>> No, more than this actually. I think this time I understand
>> better. And it appears to me that only _AC_OUTPUT_SUBDIRS needs
>> being fixed. Back to your patch, here are the chunks which make
>> sense to me. I'd OK a patch (address@hidden) with
>> ChangeLog for them.
Tim> Great!
>> Why do you use ac_sub_cache_opt and sub_srcdir_opt? Just this
>> seems enough:
>>
>> + case $ac_sub_srcdir in +[ *" "*|*"
>> "*|*[\[\]\~\#\$\^\&\*\(\)\{\}\\\|\;\<\>\?\"\']*)] +
>> ac_sub_srcdir=`echo "$ac_sub_srcdir" | sed "s/'/'\\\\\\\\''/g"` +
>> esac
Tim> To have the same effect as the argument quoting done by autoconf,
Tim> resulting in '--srcdir=foo\bar' (including the quotes). Note that
Tim> the sed only escapes single quotes; it relies on the result being
Tim> enclosed in single quotes to preserve the other metachars. I'm
Tim> not sure it would be wise to use the above and then always pass
Tim> --srcdir='$ac_sub_srcdir' to the sub-configure, as those quotes
Tim> might break something if used when they're not needed (not sure
Tim> about that though; basically I thought it would be safest to
Tim> stick to the method autoconf currently uses for quoting arguments
Tim> with metachars).
OK, that's a valid point, but currently I see no part of configure
which might depend on this, nor should there be IMHO.
- Argument quoting problem when processing config_subdirs, Tim Van Holder, 2001/01/06
- RE: Argument quoting problem when processing config_subdirs, Tim Van Holder, 2001/01/06
- RE: Argument quoting problem when processing config_subdirs, Tim Van Holder, 2001/01/06
- RE: Argument quoting problem when processing config_subdirs, Tim Van Holder, 2001/01/06
- Re: Argument quoting problem when processing config_subdirs, Akim Demaille, 2001/01/11
- Re: Argument quoting problem when processing config_subdirs, Pavel Roskin, 2001/01/11
- RE: Argument quoting problem when processing config_subdirs, Tim Van Holder, 2001/01/11
- Re: Argument quoting problem when processing config_subdirs, Akim Demaille, 2001/01/15
- Re: Argument quoting problem when processing config_subdirs, Akim Demaille, 2001/01/15
- Re: Argument quoting problem when processing config_subdirs,
Akim Demaille <=