Re: confusing message in AC_PROG_MAKE_SET

[Akim Demaille]

>>>>> "Bruno" == Bruno Haible <address@hidden> writes:

Bruno> Akim Demaille writes:
>> | Btw, here is a test makefile that tests for MAKE being set as a
>> shell | variable, and this tests fails with GNU make.
>> | 
>> | all: | @eval echo 'ac_maketemp="$$''{MAKE}"'
>> 
>> I don't understand what you mean here.  Are you suggesting an
>> additional test?

Bruno> No, I only meant to convince you that GNU make does not set the
Bruno> shell/environment variable ${MAKE}.

Thanks.  I'm installing this:

Index: ChangeLog
from  Akim Demaille  <address@hidden>

        * lib/autoconf/programs.m4 (AC_PROG_MAKE_SET): Use and display
        `$(MAKE)' instead of '${MAKE}' to emphasize that we refer to the
        Make variable, not a shell variable.
        Suggested by Bruno Haible.

Index: doc/autoconf.texi
===================================================================
RCS file: /cvsroot/autoconf/autoconf/doc/autoconf.texi,v
retrieving revision 1.707
diff -u -u -r1.707 autoconf.texi
--- doc/autoconf.texi 30 Oct 2002 09:00:24 -0000 1.707
+++ doc/autoconf.texi 31 Oct 2002 13:12:39 -0000
@@ -1688,9 +1688,10 @@
 @defmac AC_PROG_MAKE_SET
 @acindex PROG_MAKE_SET
 @ovindex SET_MAKE
-If @command{make} predefines the variable @code{MAKE}, define output
-variable @code{SET_MAKE} to be empty.  Otherwise, define @code{SET_MAKE}
-to contain @samp{MAKE=make}.  Calls @code{AC_SUBST} for @code{SET_MAKE}.
+If @command{make} predefines the Make variable @code{MAKE}, define
+output variable @code{SET_MAKE} to be empty.  Otherwise, define
address@hidden to contain @samp{MAKE=make}.  Calls @code{AC_SUBST} for
address@hidden
 @end defmac
 
 If you use this macro, place a line like this in each @file{Makefile.in}
Index: lib/autoconf/programs.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/autoconf/programs.m4,v
retrieving revision 1.12
diff -u -u -r1.12 programs.m4
--- lib/autoconf/programs.m4 28 Sep 2002 14:07:47 -0000 1.12
+++ lib/autoconf/programs.m4 31 Oct 2002 13:12:39 -0000
@@ -457,12 +457,12 @@
 AN_MAKEVAR([MAKE], [AC_PROG_MAKE_SET])
 AN_PROGRAM([make], [AC_PROG_MAKE_SET])
 AC_DEFUN([AC_PROG_MAKE_SET],
-[AC_MSG_CHECKING([whether ${MAKE-make} sets \${MAKE}])
+[AC_MSG_CHECKING([whether ${MAKE-make} sets \$(MAKE)])
 set dummy ${MAKE-make}; ac_make=`echo "$[2]" | sed 'y,./+-,__p_,'`
 AC_CACHE_VAL(ac_cv_prog_make_${ac_make}_set,
 [cat >conftest.make <<\_ACEOF
 all:
-       @echo 'ac_maketemp="${MAKE}"'
+       @echo 'ac_maketemp="$(MAKE)"'
 _ACEOF
 # GNU make sometimes prints "make[1]: Entering...", which would confuse us.
 eval `${MAKE-make} -f conftest.make 2>/dev/null | grep temp=`