[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: top_builddir vs. builddir
From: |
Paul Eggert |
Subject: |
Re: top_builddir vs. builddir |
Date: |
Wed, 02 Feb 2005 16:54:13 -0800 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) |
Stepan Kasal <address@hidden> writes:
> Would you like the attached patch?
> (You have to bootstrap ./configure before "make check".)
Yes, that looks like the right idea, but I noticed a couple of
problems. There should be a NEWS item.
And in the following changes, it seems to me that "$at_top_build_prefix"
should not be followed by "/". I realize this problem is in the original.
(I have only inspected the code, not run it.)
> - at_path=$at_path$at_top_builddir/$as_dir$PATH_SEPARATOR
> + at_path=$at_path$at_top_build_prefix/$as_dir$PATH_SEPARATOR
> at_path=$at_path$at_top_srcdir/$as_dir
> fi
> ;;
> @@ -869,8 +869,8 @@
> echo
> fi
> if test -n "$at_top_srcdir"; then
> - AS_BOX([$at_top_builddir/config.log])
> - sed 's/^/| /' $at_top_builddir/config.log
> + AS_BOX([$at_top_build_prefix/config.log])
> + sed 's/^/| /' $at_top_build_prefix/config.log
> echo
> fi
> } >&AS_MESSAGE_LOG_FD
Anyway, after you've reviewed/fixed this, please install.