bug-autoconf
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GNU Autoconf 2.59c] testsuite: 1 6 7 11 50 51 52 53 54 55 56 57 59


From: Stepan Kasal
Subject: Re: [GNU Autoconf 2.59c] testsuite: 1 6 7 11 50 51 52 53 54 55 56 57 59 60 61 62 63 64 65 66 67 70 71 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116
Date: Thu, 26 May 2005 08:49:57 +0200
User-agent: Mutt/1.4.1i

Hello,

On Wed, May 25, 2005 at 11:38:43AM -0700, Paul Eggert wrote:
> > awk '/^ \t*case/,/^ \t*esac/{if(/\[\^.*\)/) exit(1)}'
> 
> That code looks incorrect.  " \t*" should be "[ \t]*", surely.

yes, ithat was my mistake, sorry.

> It's better to remove the test for now.

I agree.  When I thoought about the test, I wasn't able to invent somethig
usable.  As you pointed out, my test
        /^[ \t]*case/,/^[ \t]*esac/{if(/\[\^.*\)/) exit(1)}
will probably have many false positives.

The previous test,
        grep '\@<:@\^.*).*;;'
was very weak; it needed the pattern and ;; on the same line.  Yet it
also had a false positive; that was what brought my attention here.
(Yes, the workaround is to put ;; on a separate line, but this is ugly.)

So I conclude there is no good solution now and it's best to let it be.
Thank you, Paul, for fixing it.

(If we had a shell which is able to complain when it sees [^..], that
would be the real fix!)

Have a nice day,
        Stepan Kasal




reply via email to

[Prev in Thread] Current Thread [Next in Thread]