[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bad m4 quotation?

From: Stepan Kasal
Subject: Re: bad m4 quotation?
Date: Thu, 6 Apr 2006 17:03:52 +0200
User-agent: Mutt/1.4.1i


On Wed, Apr 05, 2006 at 07:20:47AM -0700, Noah Misch wrote:
> On Tue, Apr 04, 2006 at 12:14:10PM -0700, Paul Eggert wrote:
> > Likewise.  Given that the patch fixes real problems, I suggest
> > installing it and waiting for the nicer fix later.
> I installed it.  Thanks for the reviews.

OK, so I followed up:
1) moved the assignments back to _AC_CONFIG_FOOS, with an m4_if
   (the ``nicer fix'')
2) re-inserted a newline after that assignment; this fixes a subtle
   regression introduced by the Noah's patch; see below for details
3) added double quotes around the tag names, as descussed before; this fixes
   a regression introduced by my rewrite of status.m4 from last summer.

ad 2):
The expansion of AS_CONFIG_FILES always ended with a newline.
Of course the AS_CONFIG_FILES call is in most cases on a line by itself;
but we should prevent regressions in cases when it is not.

Since most of this was discussed earlier in this thread, I took the liberty
to commit these changes.

And since I think that Noah's patch didn't go to autoconf-patches, I'm
cc'ing this mail there and attaching a combined version of both patches.

Have a nice day,

Attachment: autoconf-20060406-tags.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]