[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mkdir -p -- minor cleanup

From: Stepan Kasal
Subject: Re: mkdir -p -- minor cleanup
Date: Mon, 24 Apr 2006 14:06:15 +0200
User-agent: Mutt/1.4.1i

Hello Ralf,

On Sat, Apr 22, 2006 at 08:44:06PM +0200, Ralf Wildenhues wrote:
> It was already noted that `-m MODE' is understood by mkdir, by
> install_sh, and by mkinstalldirs (the latter would not be used
> any more, I'm just noting it here).
> However, we can't be sure that there is no race here, since
> the mode may be set strictly later than directory creation by
> some of those scripts.   For an Autoconf macro, and maybe even
> for Automake, it may be worthwhile to fix this:
>   su -c 'make install DESTDIR=/tmp/dest'
> should not require me to think about setting a proper umask first.

a quick look shows that the current install-sh indeed contains this
race condition.  You are probably right that we should fix this and
review current GNU mkdir before we enhace the documentation to
encourage people to use "$(mkdir_p) -m MODE"

But I don't think this is a blocker for Paul's patch.
All my complaints were considered, and we have Alexandre's approval,
so I guess you could check it in.

Have a nice day,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]