bug-autoconf
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix for fugly autoconf 2.62 bug


From: Eric Blake
Subject: Re: fix for fugly autoconf 2.62 bug
Date: Mon, 21 Apr 2008 06:20:23 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080213 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Per Øyvind Karlsen on 4/18/2008 7:58 PM:
| Hi!

Hello Per,

|
| Since we upgraded to latest autoconf in Mandriva, we've discovered some
nasty
| bug in autoconf breaking build of quite a few packages.

Please report autoconf bugs to the address@hidden mailing list, and
not to private developers.  You will reach a much larger audience, and be
much more likely to achieve results.

|
| What happens is that 'eval' doesn't necessarily threat the line as just one
| line, so if some variable is multi line, the additional lines will be
ends up
| on different lines. This patch will ensure to remove all newlines from the
| variables.

Can you please show an example configure.ac or even a pointer to a project
where this bug bit you?  We need to add something to our testsuite before
blindly applying a patch.

|
| I guess some prettier way can be found, but this one will at least work for
| now with all tests passing and pointing out the bug. Probably a good
idea to
| add a check to the testsuite for this as well.
|
| Gentoo d00dz: Doing a quick google on the topic, I noticed that you guys
had
| this issue reported in your bugzilla (ie.
| http://bugs.gentoo.org/show_bug.cgi?id=217272), so here's a fix for ya! :)

This bug has nothing to do with your claim of an eval bug, but deals with
the deprecation of older macros by the newer AC_USE_SYSTEM_EXTENSIONS
(where the fix is indeed to quit using AC_AIX and AC_MINIX macros in favor
of the new macro).

|
| Patch available at:
|
http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/autoconf/current/SOURCES/autoconf-2.62-fix-multiline-string.patch?view=log

It looks like all this patch does is change newlines to spaces in
computing config_files and friends.  I'm not a fan of adding extra forks
to configure unless we can prove that such a fix is necessary; I also
wonder if your patch introduces any line length limitation bugs.  Again,
we need some context as to why you are reporting this as a bug.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkgMhocACgkQ84KuGfSFAYBjygCeJoP0NkIR2fAr3ZdqDy0Yts4j
odcAn3tdLh8MIWw6kZVQTWMXSTakx9ON
=6VQi
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]