[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: autoconf-2.62: `make install' fails if file system is case insensiti
Re: autoconf-2.62: `make install' fails if file system is case insensitive
Thu, 5 Jun 2008 21:59:22 +0000 (UTC)
Stepan Kasal <kasal <at> ucw.cz> writes:
> Hello Eric,
Hello Stepan, and thanks for the ideas,
> Consequently, I'd like to propose an alternate solution:
> if configure detects case-insensitive make, the rule for
> $(srcdir)/INSTALL would be disabled.
> That should not be a problem, as case insensitive platforms are
> rarely used to create the distribution tarball of Autoconf.
This seems reasonable; but how does it interact with the fact that cfg.mk
currently defines the make macro _autoreconf to remove INSTALL? I think that
definition also needs conditioning (ie. if on a case-insensitive make, it seems
like cfg.mk must not redefine _autoreconf from its default in GNUmakefile).
> Attached please find a patch.
> The main advantage of this patch is that it is conservative:
> - in the common situation, things work exactly as before
> - the extra code is hidden in one macro, so the code is not made less
> OK to commit?
Other than my nit about _autoreconf, I don't see any technical flaws in your
patch. But I'd feel a lot more comfortable if someone actually tested your
patch on the case-insensitive MSYS make (or at least the algorithm in the .m4
file) to ensure that we will correctly detect the situation, before applying