[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Spurious error from autoheader

From: Eric Blake
Subject: Re: Spurious error from autoheader
Date: Mon, 04 Aug 2008 06:38:08 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20080708 Thunderbird/ Mnenhy/

Hash: SHA1

[responding to a patch posted a month ago:

According to Stepan Kasal on 6/30/2008 12:39 PM:
| But I see another problem here:
| autoheader calls this "warning", but it does not create
| config.h.in then.  Even worse, if config.h.in existed, it's not
| updated.
| The mistake was introduced by a change almost
| 5 years old!  The attached diff documents it.
| Possible solutions:
| - update the template anyway
| - call it an error, removing the obsolete template.
| - call it an error, leaving template as it is
| In my opinion, the above are in decreasing order of preference.

I'm okay with updating the template anyway; does the patch you attached do
this, or is this something where a patch has not yet been written?  Are
you able to tackle this?

| 2003-08-27  Akim Demaille  <address@hidden>
| +     * bin/autoheader.in: Issue the "Using auxiliary..." message only
| +     when -Wobsolete is set.
| +     Set it on by default.
| +     Suggested by Klee Dienes.

The patch you attached is confusing me - the ChangeLog attributes a
different author than the person writing the email, and attributes a
different reporter than the original poster in this thread.  Is this
something that Akim patched independently of Andreas' report, and which
you noticed?  Where are you seeing Akim's patches, and are any other
patches worth folding in upstream?  It looks like a reasonable patch, but
I'd like to know more details about it before okay'ing it for inclusion.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


reply via email to

[Prev in Thread] Current Thread [Next in Thread]