[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Calling AC_USE_SYSTEM_EXTENSIONS through several of its alia
Re: [PATCH] Calling AC_USE_SYSTEM_EXTENSIONS through several of its aliases should not issue a cryptic warning
Fri, 10 Oct 2008 06:42:24 -0600
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:18.104.22.168) Gecko/20080914 Thunderbird/22.214.171.124 Mnenhy/0.7.5.666
-----BEGIN PGP SIGNED MESSAGE-----
According to Stepan Kasal on 10/8/2008 11:11 AM:
> it used to be usual to call
> What do you think about the following patch?
> I see it slightly changes the semantics of AC_USE_SYSTEM_EXTENSIONS
> (the code is moved outside the outermost ac_defuned macro), do you
> think this is OK?
> Or is it OK to commit?
> Have a nice day,
> * lib/autoconf/specific.m4 (AC_USE_SYSTEM_EXTENSIONS): Move
> the body to ...
> (_AC_USE_SYSTEM_EXTENSIONS): ... this new macro and require it
> from the original and ...
> (AC_GNU_SOURCE, AC_AIX, AC_MINIX): ... from all of these.
I think it looks sound; it ensures that the code is expanded only once,
instead of once for each variant spelling. If you wouldn't mind, can you
also write up a NEWS item before applying?
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----