[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] use diff --strip-tailing-cr when possible

From: Ralf Wildenhues
Subject: Re: [PATCH] use diff --strip-tailing-cr when possible
Date: Tue, 28 Jul 2009 20:36:30 +0200
User-agent: Mutt/1.5.20 (2009-06-15)

Hello Robert,

* Robert Millan wrote on Fri, Jul 24, 2009 at 08:36:59PM CEST:
> This patch makes it possible to use autotest on MingW32/Wine, where
> DOS carriage returns are printed, breaking the testsuite (for the
> record, problem was found with GNU cpio's testsuite).

In addition to Eric's review,

> +# Use `diff --strip-trailing-cr' when possible.
> +if at_diff_tmp=`$at_diff -u "$at_devnull" "$at_devnull" 2>&1` && test -z 
> "$at_diff_tmp"

this test does not really ensure that --strip-trailing-cr is accepted by
the diff program.  So if you add another macro that compares only text
files (say AT_CHECK_TEXT_FILE or so), ignoring line endings, it should
test this option.  If the option is not supported, then another means
should be used to normalize the files for the test, e.g., by using tr,
so that the functionality can be provided portably.

For example, Libtool's new testsuite does something similar within its

> +then
> +  at_diff="$at_diff --strip-trailing-cr"
>  fi
>  # Get the last needed group.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]