bug-autoconf
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: feature request: allow plus signs in AC_ARG_ENABLE


From: Bruno Haible
Subject: Re: feature request: allow plus signs in AC_ARG_ENABLE
Date: Sat, 13 Mar 2010 21:49:54 +0100
User-agent: KMail/1.9.9

Ralf Wildenhues wrote:
> Those semantics already have users out there, though.  For example GCC
> relies on --disable-libstdc___v3, so this would be an incompatible
> change.

OK, the name of the variable is not important to me (the user can define
his own variable anyway). Here's a revised patch:


2010-03-13  Bruno Haible  <address@hidden>

        * doc/autoconf.texi (External Software): Mention that AC_ARG_WITH
        accepts packages with a + sign in it.
        (Package Options): Likewise for AC_ARG_ENABLE.
        * lib/autoconf/general.m4 (_AC_ENABLE_IF): Also replace '+' with '_'.

--- doc/autoconf.texi.orig      Sat Mar 13 21:48:56 2010
+++ doc/autoconf.texi   Sat Mar 13 21:48:51 2010
@@ -20491,7 +20491,7 @@
 @var{action-if-given}.  If neither option was given, run shell commands
 @var{action-if-not-given}.  The name @var{package} indicates another
 software package that this program should work with.  It should consist
-only of alphanumeric characters, dashes, and dots.
+only of alphanumeric characters, dashes, plus signs, and dots.
 
 The option's argument is available to the shell commands
 @var{action-if-given} in the shell variable @code{withval}, which is
@@ -20643,7 +20643,7 @@
 shell commands @var{action-if-given}.  If neither option was given, run
 shell commands @var{action-if-not-given}.  The name @var{feature}
 indicates an optional user-level facility.  It should consist only of
-alphanumeric characters, dashes, and dots.
+alphanumeric characters, dashes, plus signs, and dots.
 
 The option's argument is available to the shell commands
 @var{action-if-given} in the shell variable @code{enableval}, which is
--- lib/autoconf/general.m4.orig        Sat Mar 13 21:48:56 2010
+++ lib/autoconf/general.m4     Sat Mar 13 21:44:11 2010
@@ -1440,7 +1440,7 @@
 #
 m4_define([_AC_ENABLE_IF],
 address@hidden:@ Check whether --$1-$2 was given.
-_AC_ENABLE_IF_ACTION([$1], m4_translit([$2], [-.], [__]), [$3], [$4])
+_AC_ENABLE_IF_ACTION([$1], m4_translit([$2], [-+.], [___]), [$3], [$4])
 ])
 
 m4_define([_AC_ENABLE_IF_ACTION],




reply via email to

[Prev in Thread] Current Thread [Next in Thread]