[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Improper substitution of @srcdir@ in VPATH template for "in-source"

From: Eric Blake
Subject: Re: Improper substitution of @srcdir@ in VPATH template for "in-source" configure
Date: Wed, 23 Jun 2010 13:29:41 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.2 Thunderbird/3.0.5

On 06/23/2010 12:20 PM, Ralf Wildenhues wrote:
> Hi Keith,
> * Keith Marshall wrote on Wed, Jun 23, 2010 at 10:58:01AM CEST:
>> Initially reported here:
>> http://thread.gmane.org/gmane.comp.gnu.mingw.user/33435/focus=33455
> Thanks for the bug report.
>>   $ cat Makefile.in
>>   # @configure_input@
>>   srcdir = @srcdir@
>>   VPATH = @srcdir@/src
>>   # EOF
>>   $ grep VPATH Makefile
>>   VPATH = /src
>> Note that this should be `VPATH = ./src', but the dot, which should 
>> have resulted from substitution of @srcdir@, has been elided.  Note 
>> however:
> The patch below should fix this.  Tested on several systems.  OK?

Yes, that makes sense.

> Space-separated VPATH entries are not portable to FreeBSD and several
> vendor makes.  I'm not quite sure if in practice we may run into make
> implementations any more that do not support
> - variable expansions at all in VPATH,
> - multiple entries in VPATH,
> - VPATH at all,
> but the manual indicates there used to be such makes.  Eric, are you ok
> with the testsuite addition being a test balloon for this?  Otherwise,
> it needs a prerequisite test for the basic functionality to avoid
> spurious failures.

Hmm, adding a test that might fail on more exotic platforms will at
least remind us to patch things on those platforms, so I guess I'm okay
with it.  At any rate, the test passes on the most common open source
development setups, and we aren't violating the portability pitfalls
exposed by this test anywhere else.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]