[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: testsuite failure - 193 parallel execution

From: Eric Blake
Subject: Re: testsuite failure - 193 parallel execution
Date: Tue, 20 Jul 2010 21:15:56 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5

On 07/20/2010 04:44 PM, Paul Eggert wrote:
> On 07/20/10 14:55, Eric Blake wrote:
>> the '|| break' that you are deleting is there in case
>> something kills off the child and it never gets around to writing a
>> token, at which point we've now put the parent into an inf-loop
> OK, though if the child is killed off arbitrarily then we're helpless
> (the first child could get killed before it opens the fifo, which
> means the parent will wait forever trying to open the fifo); but I
> see what you mean: that patch made infinite loops too likely in
> the presence of arbitrary child failure.
> How about this idea instead: have the parent open the fifo for
> output, except do this _after_ the first job has started (so
> we know we can open the fifo without hanging, under the same
> assumptions as before).  That way, the race condition is closed.

Bingo.  Passed on my machine with flying colors, without having to
resort to 'env echo' to slow things down.  Final patch coming up shortly.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]