[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: testsuite failure - 193 parallel execution

From: Eric Blake
Subject: Re: testsuite failure - 193 parallel execution
Date: Tue, 20 Jul 2010 21:34:05 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5

On 07/20/2010 09:23 PM, Ralf Wildenhues wrote:
>> +  exec AT_JOB_OUTFIFO_FD<&-
> Doesn't this have to be
>      exec AT_JOB_OUTFIFO_FD>&-
> instead?

Technically, no: n>&- and n<&- are identical, regardless of what mode
the fd was originally opened in (and must be, so that you can blindly do
'exec 5<&-' to close a possibly-inherited fd 5 without knowing what mode
it was opened in, all without error if fd 5 is not already open).
[Plain <&- and >&- differ, but only because they default to 0<&- and
1>&-].  But for readability, yes, it should be consistent, since we know
that fd is opened for output.  I already fixed that in my pending patch

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]