[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {msvc} Regenerate with autoconf 2.67

From: Eric Blake
Subject: Re: [PATCH] {msvc} Regenerate with autoconf 2.67
Date: Wed, 15 Sep 2010 16:49:16 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100907 Fedora/3.1.3-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.3

On 09/15/2010 09:48 AM, Stefano Lattarini wrote:

(which has since been fixed in the pkg-config git repo, BTW).
There should be a reference also on the autoconf list

Yes, it looks like this is the same topic:

You might want to look at commit 2b86e9b4664fd43622e2cd5ab47713a818758970
in the pkg-config git repository:

I needed to see more context. Is there a gitweb URL for this commit? http://pkg-config.freedesktop.org/wiki/ wasn't as helpful; it only listed how to clone the repository instead of browsing it on the web.

At any rate, after cloning the file, and looking at

$ git show 2b86e9b:pkg.m4

I see that pkg-config was roughly doing:


and expecting _PKG_TEXT to be recognized as a macro name. AC_MSG_ERROR is a synonym for AS_ERROR, which indeed changed in 2.66, in commit

The key part to note is this chunk:

-[m4_ifvaln([$2], [{ AS_SET_STATUS([$2])])]dnl
-[as_fn_error "_AS_QUOTE([$1])"m4_ifval(AS_MESSAGE_LOG_FD,
- [ "$LINENO" AS_MESSAGE_LOG_FD])[]m4_ifval([$2], [; }])])
+[as_fn_error m4_default([$2], [$?]) "_AS_QUOTE([$1])"m4_ifval(AS_MESSAGE_LOG_FD,

The macro used to end with '}', but now ends with AS_MESSAGE_LOG_FD. So it is indeed an autoconf regression. Adding the [] should fix it; I'm working on patching the testsuite to catch this first, though.

Thanks for persisting on this one!

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]