[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: incomplete warning message

From: Eric Blake
Subject: Re: incomplete warning message
Date: Mon, 20 Sep 2010 15:56:15 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100907 Fedora/3.1.3-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.3

On 09/20/2010 02:59 PM, Ralf Wildenhues wrote:
Yes, that looks sane, thanks.  Remember that each `partial =>  1' message
must be finished by a non-partial part, otherwise it may not be seen.

Since my perl is weak, are there any
suggestions on more robust ways to express this action?

Searching for newlines in the first regex?  You want it to be partial
exactly if you print more lines.

After staring at it some more, and running my testsuite addition, I'm confident my solution is correct. In m4sugar.m4, m4_warn is defined as giving a third argument to _m4_warn that will either be empty, or be the expansion of m4_expansion_stack, which always ends with "the top level". Yes, it means that m4sugar.m4 and autom4te.in are tied rather closely together, but I'm happy enough with the fix that I'm going ahead and pushing it.

We can optimize things later, such as making Channels.pm friendlier for ending a batch of partial messages without having to decide within a split whether a particular line is the last part of the message. But that can be after 2.68.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]