[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug #593838: AX_CFLAGS_GCC_OPTION misuses AS_VAR_PUSHDEF variable

From: Eric Blake
Subject: Re: Bug #593838: AX_CFLAGS_GCC_OPTION misuses AS_VAR_PUSHDEF variable
Date: Fri, 08 Oct 2010 10:57:59 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100921 Fedora/3.1.4-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.4

On 10/01/2010 10:35 AM, Eric Blake wrote:
That assumes, of course, that I can easily fix the regression of
AS_PUSH_VAR accepting a var-name with = in it ;) It may not be today,
but it's certainly on my list of things to tackle during the first week
of October.

Oops - it's the 8th; I missed my 'first week of October'.

Found the problem:
AS_LITERAL_IF([a+b],1,2,3) => 1
AS_LITERAL_IF([a=b],1,2,3) => 2

Basically, + and = should be treated identically, which is the case after this two-character addition (more formal patch coming up after further testing):

diff --git c/lib/m4sugar/m4sh.m4 w/lib/m4sugar/m4sh.m4
index 13ad849..3c9350a 100644
--- c/lib/m4sugar/m4sh.m4
+++ w/lib/m4sugar/m4sh.m4
@@ -1584,8 +1584,8 @@ m4_define([AS_LITERAL_IF],

 [m4_if(m4_index([$1], address@hidden|@]), [-1], [$0_(m4_translit([$1],
-  [-:%/@{}[]#(),.$2]]]m4_dquote(m4_dquote(m4_defn([m4_cr_symbols2])))[[,
-  [+++++$$`````]))], [$0_NO])])
+  [-:=%/@{}[]#(),.$2]]]m4_dquote(m4_dquote(m4_defn([m4_cr_symbols2])))[[,
+  [++++++$$`````]))], [$0_NO])])

 [m4_if(m4_translit([$1], [+]), [], [$0YES],

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]