[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

test -z and test -n DESTDIR support

From: James Smith
Subject: test -z and test -n DESTDIR support
Date: Wed, 25 Jul 2012 14:32:58 +1000
User-agent: Internet Messaging Program (IMP) H3 (4.3.11)


I've found two spots where DESTDIR support is omitted. I tried to track down where the problem is in the autoconf source without success, so I present to you a diff on git OpenVPN's Makefile.in (see attached). I *think* the bug is in lib/autoconf/programs.m4 from my grepping but I really am not sure.

I built autoconf from git (as at 2012-07-25 01:41 UTC), following the instructions in README-hacking. OpenVPN source came from git (as at 2012-07-25 02:28 UTC). Using my built autoconf, I issued autoreconf -vi in my OpenVPN git directory. The generated Makefile.in needed to be corrected as in the attached diff.

I've also attached tests/testsuite.log as requested on the autoconf home page.

Note this seems to happen with any Makefile.in, but I know for sure it happens with OpenVPN. It's probable there were other Makefile.ins in the OpenVPN tree that needed patching, but it looks like the bug comes from one source, so it didn't seem necessary to send diffs for them too.

Hope this helps.

Attachment: testsuite.log
Description: Text Data

Attachment: openvpn-git-destdir.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]