[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: test -z and test -n DESTDIR support

From: Eric Blake
Subject: Re: test -z and test -n DESTDIR support
Date: Wed, 25 Jul 2012 07:40:16 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0

On 07/24/2012 10:32 PM, James Smith wrote:
> Hello,
> I've found two spots where DESTDIR support is omitted. I tried to track
> down where the problem is in the autoconf source without success, so I
> present to you a diff on git OpenVPN's Makefile.in (see attached). I
> *think* the bug is in lib/autoconf/programs.m4 from my grepping but I
> really am not sure.

Thanks for the report, however, you are blaming the wrong culprit.

> --- openvpn/Makefile.in       2012-07-25 12:13:24.000000000 +1000
> +++ openvpn/Makefile.in.new   2012-07-25 12:32:06.000000000 +1000
> @@ -430,8 +430,8 @@
>       -rm -f libtool config.lt
>  install-dist_docDATA: $(dist_doc_DATA)
>       @$(NORMAL_INSTALL)
> -     test -z "$(docdir)" || $(MKDIR_P) "$(DESTDIR)$(docdir)"
> -     @list='$(dist_doc_DATA)'; test -n "$(docdir)" || list=; \
> +     test -z "$(DESTDIR)$(docdir)" || $(MKDIR_P) "$(DESTDIR)$(docdir)"
> +     @list='$(dist_doc_DATA)'; test -n "$(DESTDIR)$(docdir)" || list=; \
>       for p in $$list; do \
>         if test -f "$$p"; then d=; else d="$(srcdir)/"; fi; \
>         echo "$$d$$p"; \

Autoconf does not create 'Makefile.in'; it only converts it into
'Makefile'.  If openVPN is using Automake, then either the bug exists in
automake or in the openVPN 'Makefile.am' file; if openVPN is not using
Automake, then the fault lies squarely on openVPN's 'Makefile.in' file.
 In other words, you should be reporting this patch to the openVPN
folks, not autoconf.

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]