Re: [GNU Autoconf 2.69.23-388d] testsuite: 35 failed (autom4te preselections)

[Stefano Lattarini]

On 09/21/2012 05:50 PM, Eric Blake wrote:
> On 09/21/2012 04:24 AM, Stefano Lattarini wrote:
>> ## ------------- ##
>> ## Test results. ##
>> ## ------------- ##
>>
>> ERROR: 1 test was run,
>> 1 failed unexpectedly.
>>
>> ## ------------------------ ##
>> ## Summary of the failures. ##
>> ## ------------------------ ##
>> Failed tests:
>> GNU Autoconf 2.69.23-388d test suite test groups:
>>
>>  NUM: FILE-NAME:LINE     TEST-GROUP-NAME
>>       KEYWORDS
>>
>>   35: tools.at:1162      autom4te preselections
> 
> Thanks for the report.  However, it is passing for me, so there's got to
> be some difference in our environments explaining your failure.
> 
>> automake (GNU automake) 1.12.2
> 
> Hmm, on my environment, it passed with automake 1.11.1; maybe it's the
> version of automake that matters?
>
Yep: and now that I know the reason of the failure, it's pretty easy to
fix it -- see the patch below.  OK to apply?

>> ./tools.at:1200: test "`find configure -newer newer`" = "" ||
>>        { diff old-requests autom4te.cache/requests; exit 1; }
> 
> Eww - we should really sort these things, so that the diff isn't so hard
> to read.  And use 'diff -u' instead of 'diff'.  Improvements to the
> testsuite just to make diagnosing the failure easier would be welcome.
>
I think I'll pass this time.

> My guess is that newer automake is now tracing a different set of
> macros, and one of them wasn't preselected.  But without an improved
> test, it's hard to see which one :)
> 
Thankfully, "git diff" on the Automake repository helped there ;-)

Thanks,
  Stefano

-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----

>From 92e553f6f8c5f97d768ef2bc715c674aa4a1d8df Mon Sep 17 00:00:00 2001
Message-Id: <address@hidden>
From: Stefano Lattarini <address@hidden>
Date: Fri, 21 Sep 2012 21:28:34 +0200
Subject: [PATCH] autom4te: update Automake preselections to reflect the changes 
in 1.12.x

Issue revealed by a failure in test "35: tools.at: autom4te preselections":
<http://lists.gnu.org/archive/html/bug-autoconf/2012-09/msg00020.html>

* lib/autom4te.in: Add 'AM_PROG_MKDIR_P'.

Helped-by: Eric Blake <address@hidden>
Signed-off-by: Stefano Lattarini <address@hidden>
---
 lib/autom4te.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/autom4te.in b/lib/autom4te.in
index a560501..d042fd8 100644
--- a/lib/autom4te.in
+++ b/lib/autom4te.in
@@ -69,6 +69,8 @@ args: --preselect AM_PROG_CXX_C_O
 args: --preselect AM_PROG_F77_C_O
 args: --preselect AM_PROG_FC_C_O
 args: --preselect AM_PROG_MOC
+# Will be removed in Automake 1.14.
+args: --preselect AM_PROG_MKDIR_P
 args: --preselect AM_SILENT_RULES
 args: --preselect AM_XGETTEXT_OPTION
 args: --preselect _AM_MAKEFILE_INCLUDE
-- 
1.7.12.317.g1c54b74