[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: about the test 501 that fail...
From: |
Eric Blake |
Subject: |
Re: about the test 501 that fail... |
Date: |
Sat, 5 Sep 2015 19:33:36 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 09/05/2015 08:57 AM, Paul Eggert wrote:
> christian fafard wrote:
>> I suggest changing the regular expression to accept both a leading
>> backtick and a leading single quote.
>>
>> \` become [\`']
>
> That would require assuming a UTF-8 locale, or some locale compatible
> with UTF-8. Although this is a reasonably safe assumption nowadays,
> it's more conservative to run libtoolize in the C locale, so that we
> don't have to worry about locale encoding when doing the test. So I
> installed the attached patch instead; please give it a try.
No, even in the C locale, libtool has switched from `' to '' quoting, so
a regex looking for ASCII backtick as the leading quote character fails
to match the new diagnostics. I don't know if libtool is even
internationalized enough to output diagnostics in the current locale, or
if it always outputs in the C locale (after all, Autoconf, and therefore
the M4sugar framework maintained by autoconf and used by libtool, is not
localized yet). So I still think Christian's original suggestion of
broadening the regular expression is needed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature