[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: configure and -Werror=unused-variable do not mix well.

From: Eric Blake
Subject: Re: configure and -Werror=unused-variable do not mix well.
Date: Fri, 27 Jan 2017 09:00:46 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 01/27/2017 05:31 AM, address@hidden wrote:
> In configure script generated by autoconf 2.13 for mozilla software
> # Generated automatically using autoconf version 2.13
> # Copyright (C) 1992, 93, 94, 95, 96 Free Software Foundation, Inc.

Wow that's old. Can you convince the project to upgrade their
configure.in file to use autoconf 2.69 instead?

> I found a few tests that failed if -Werror=unsed-variable is defined for
> CFLAGS (an environment variable).

Generally, ANY use of -Werror during configure is going to cause
problems. Our general advice is "don't do that".  If you want to test if
a particular warning flag is supported, do so (and in fact, there's
patches posted that I still want to incorporate into autoconf 2.70 that
make warning flag probing easier) - but only for the duration of that
test.  Don't actually change CFLAGS for the rest of the configure suite.
 GNU Coreutils is a good example of how to probe for -Werror and even
use it via a separate Makefile.am variable, without having it on to mess
with the rest of the configure probes.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]