[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: getdate.lo is linked twice to libgnu.la
From: |
Simon Josefsson |
Subject: |
Re: getdate.lo is linked twice to libgnu.la |
Date: |
Wed, 13 Sep 2006 15:56:16 +0200 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) |
Ralf Wildenhues <address@hidden> writes:
> I think the fix is to drop the AC_LIBOBJ line from getdate.m4. But
> Automake also could warn against this (it warns in a slightly simpler
> setting not involving built sources). For this however, gnulib-tool
> should use $(LIBOBJS) instead of @LIBOBJS@ in the Makefile.am snippet
> that it outputs (so that automake has a chance to detect this). Why
> doesn't gnulib-tool do that, by the way?
Making that change does not appear to change anything. I still get:
ar cru libgnu.a allocsa.o getdate.o xalloc-die.o mktime.o exitfail.o getdate.o
gettime.o xmalloc.o
However, it seems arguable correct (right?), so I propose to install
the patch below in gnulib-tool. Ok?
/Simon
--- gnulib-tool 12 Sep 2006 17:37:41 +0200 1.159
+++ gnulib-tool 13 Sep 2006 15:50:00 +0200
@@ -1098,7 +1098,7 @@
fi
echo
echo "${libname}_${libext}_SOURCES ="
- echo "${libname}_${libext}_LIBADD = @${perhapsLT}LIBOBJS@"
+ echo "${libname}_${libext}_LIBADD = \$(${perhapsLT}LIBOBJS)"
if test "$libtool" = true; then
echo "${libname}_${libext}_LDFLAGS = \$(AM_LDFLAGS)"
fi