Re: [PATCH] * tests/defs.in (required=GNUmake): Do not call $MAKE with -v.

[Ralf Wildenhues]

Hi Stepan,

Thanks for the patch.

* Stepan Kasal wrote on Fri, Dec 14, 2007 at 08:51:45PM CET:
> ---
> Hi,
>   I noticed the following detail.  Since we have to grep the output of
> make --version for GNU, we catch SGI make, I suppose.
> 
> So I think the special trick for SGI, which was in use before the
> commit 693c934 is no longer needed.
> 
> If you agree, please commit and push the following patch.

I agree with your analysis, but I don't think making the code a couple
of bytes shorter at the expense of making it more subtle and less
obvious is helpful.  Thus I am not applying this.

Cheers,
Ralf

> +2007-12-14  Stepan Kasal  <address@hidden>
> +
> +     * tests/defs.in (required=GNUmake): Do not call $MAKE with -v.
> +
>  2007-12-08  Ralf Wildenhues  <address@hidden>
>  
>       * lib/Automake/FileUtils.pm (open_quote): New function.
> diff --git a/tests/defs.in b/tests/defs.in
> index a797a82..e8ebd3a 100644
> --- a/tests/defs.in
> +++ b/tests/defs.in
> @@ -119,11 +119,10 @@ do
>        ( etags --version -o /dev/null ) || exit 77
>        ;;
>      GNUmake)
> -      # Use --version AND -v, because SGI Make doesn't fail on --version.
> -      # Also grep for GNU because newer versions of FreeBSD make do
> -      # not complain about `--version' (they seem to silently ignore it).
> -      echo "$me: running $MAKE --version -v | grep GNU"
> -      ( $MAKE --version -v | grep GNU ) || exit 77
> +      # grep for GNU because newer versions of FreeBSD make do not
> +      # complain about `--version' (they seem to silently ignore it).
> +      echo "$me: running $MAKE --version | grep GNU"
> +      ( $MAKE --version | grep GNU ) || exit 77
>        ;;
>      gcc)
>        # When gcc is required, export `CC=gcc' so that ./configure