Re: [t2] Re: Where are the version controlled Bash sources?

[Juergen "George" Sawinski]

Hi Chet.

Chet Ramey wrote:
> George wrote:
>
> > We have created a patch which is available at
> > http://svn.exactcode.de/t2/trunk/package/shells/bash/segfault-on-assign-dynamic.patch 
> >
> >
> > Maybe you can comment on it.
>
>
> It's not correct to make every builtin dynamic variable non-unsettable.
> Kind of like dragging out the heavy guns for something that requires a
> target pistol.
>
> Chet

Actually the problems seems to be somewhere else:

--- bash-3.0/variables.c        2005-01-03 23:28:24.496779416 +0100
+++ bash-3.0-t2/variables.c     2005-01-04 05:16:11.586499592 +0100
@@ -1260,7 +1260,7 @@
   if (rl_completer_word_break_characters == 0 && 
bash_readline_initialized == 0)
     enable_hostname_completion (perform_hostname_completion);

-#if 0
+#if 1
   FREE (value_cell (var));
   p = savestring (rl_completer_word_break_characters);

If I use this code in get_comp_wordbreaks (var), the segfault is also gone.

Comments?

George