[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

compiler warnings

From: Tim Waugh
Subject: compiler warnings
Date: Tue, 8 Mar 2005 13:24:47 +0000
User-agent: Mutt/

When compiling bash with GCC there are a number of alarming-looking
warnings, and several of them could be avoided by minor changes to the
code.  For example:

bashline.c:2976: warning: suggest parentheses around assignment used
as truth value

  for (passc = 0; c = string[i]; i++)

This could more readably be written:

  for (passc = 0; (c = string[i]) != '\0'; i++)

Would you be willing to accept patches to make changes such as this?


Attachment: pgpVgzZmdg13J.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]