bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: echo "enhancement" leads to confused legacy script tools...


From: Ralf Wildenhues
Subject: Re: echo "enhancement" leads to confused legacy script tools...
Date: Tue, 21 Mar 2006 17:32:44 +0100
User-agent: Mutt/1.5.11

* Ralf Wildenhues wrote on Tue, Mar 21, 2006 at 05:02:49PM CET:
> 
> The issue is not in Autoconf, but in the macro AC_CREATE_PREFIX_CONFIG_H
[...]
> I will look into that, and post an update.

To finish this up for squid:  Please install the patches below (it'd be
nice if you could feed back the cppunit related ones to their upstream),
install the file lib/cppunit-1.10.0/config/ax_prefix_config_h.m4 from
http://autoconf-archive.cryp.to/ax_prefix_config_h.html (you can remove
ac_create_prefix_config_h.m4 then), and rerun the autotools.

The first patch is an unrelated bugfix.  The second one gets cppunit in
line with better Autoconf style (portable to older versions, but
necessary for newer ones), and makes use of AX_PREFIX_CONFIG_H.

I will followup (on bug-autoconf only) with a bug in CVS Autoconf that I
just discovered, that led me to thinking the AX_PREFIX_CONFIG_H macro
was broken..

Cheers,
Ralf

        * configure.in: Call AM_PROG_CC_C_O right after AC_PROG_CC.
        Do not call AC_PROG_CC again.

Index: configure.in
===================================================================
RCS file: /squid/squid3/configure.in,v
retrieving revision 1.401
diff -u -r1.401 configure.in
--- configure.in        20 Mar 2006 23:38:23 -0000      1.401
+++ configure.in        21 Mar 2006 16:27:38 -0000
@@ -26,9 +26,9 @@
 
 dnl Check for GNU cc
 AC_PROG_CC
+AM_PROG_CC_C_O
 AC_LANG_C
 AC_PROG_CXX
-AM_PROG_CC_C_O
 AC_CANONICAL_HOST
 AC_DISABLE_SHARED
 AC_PROG_LIBTOOL
@@ -99,9 +99,6 @@
 
 AC_DEFINE_UNQUOTED(SQUID_CONFIGURE_OPTIONS, "$ac_configure_args", [configure 
command line used to configure Squid])
 
-dnl Check for GNU cc
-AC_PROG_CC
-
 dnl Gerben Wierda <address@hidden>
 case "$host" in
     mab-next-nextstep3)



        * configure.in: Use AC_CONFIG_FILES to list config files.
        Use AX_PREFIX_CONFIG_H instead of AC_CREATE_PREFIX_CONFIG_H.

Index: lib/cppunit-1.10.0/configure.in
===================================================================
RCS file: /squid/squid3/lib/cppunit-1.10.0/configure.in,v
retrieving revision 1.2
diff -u -r1.2 configure.in
--- lib/cppunit-1.10.0/configure.in     27 Sep 2004 17:32:39 -0000      1.2
+++ lib/cppunit-1.10.0/configure.in     21 Mar 2006 16:21:13 -0000
@@ -117,8 +117,7 @@
 #AC_DEFINE_UNQUOTED(NO_TESTPLUGIN,$testplugin_val,
 #[defined to disable TestPlugIn])
 
-
-AC_OUTPUT([
+AC_CONFIG_FILES([
   Makefile 
   cppunit.spec
   cppunit-config
@@ -147,5 +146,7 @@
   examples/money/Makefile
 ],[chmod a+x cppunit-config])
 
-AC_CREATE_PREFIX_CONFIG_H([include/cppunit/config-auto.h], 
+AX_PREFIX_CONFIG_H([include/cppunit/config-auto.h], 
         $PACKAGE, [config/config.h])
+
+AC_OUTPUT




reply via email to

[Prev in Thread] Current Thread [Next in Thread]