bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bash-testers] Re: readline-5.2-1 prompt issue on cygwin


From: Eric Blake
Subject: Re: [bash-testers] Re: readline-5.2-1 prompt issue on cygwin
Date: Fri, 10 Nov 2006 07:24:53 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.8) Gecko/20061025 Thunderbird/1.5.0.8 Mnenhy/0.7.4.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Eric Blake on 11/9/2006 10:10 PM:
> 
> Indeed, this alternative patch also seems to fix the test case for me:
> 
> --- bash-3.2-orig/lib/readline/display.c   2006-09-14 12:20:12.000000000
> -0600
> +++ bash-3.2/lib/readline/display.c     2006-11-09 22:08:26.249000000 -0700
> @@ -2380,6 +2380,8 @@ _rl_col_width (str, start, end)
> 
>    if (end <= start)
>      return 0;
> +  if (MB_CUR_MAX == 1)
> +    return end - start;
> 
>    memset (&ps, 0, sizeof (mbstate_t));
> 
> 

Using just the above patch to _rl_col_width, I have verified that ALL of
the prompt display bugs reported to cygwin over the past year and a half
are fixed; I haven't been able to come up with any broken scenarios.  I
guess there aren't that many platforms that provide mbrtowc and compile
readline with multibyte support, yet run a locale with MB_CUR_MAX == 1 by
default.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFVIu184KuGfSFAYARArJfAKCNFJFPKMiuNgALMlqwsqsgIUNNGQCgs7Ny
6kuy+VNaheBrKiS0knaDL90=
=kXTd
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]