Re: bash40-011 patch can't be applied cleanly

[Sergei Steshenko]

--- On Wed, 11/18/09, Sergei Steshenko <sergstesh@yahoo.com> wrote:

> From: Sergei Steshenko <sergstesh@yahoo.com>
> Subject: bash40-011 patch can't be applied cleanly
> To: bug-bash@gnu.org
> Date: Wednesday, November 18, 2009, 5:43 PM
> Hello,
> 
> here is screen output of patches application process:
> 
> "
> build.pl :INFO: executing ==> cd
> /mnt/sdb8/sergei/AFSWD_debug/build/bash-4.0/../bash-4.0-patches;
> \patch -p0 < bash40-001
> patching file ../bash-4.0/parse.y
> patching file ../bash-4.0/patchlevel.h
> build.pl :INFO: executing ==> cd
> /mnt/sdb8/sergei/AFSWD_debug/build/bash-4.0/../bash-4.0-patches;
> \patch -p0 < bash40-002
> patching file ../bash-4.0/pcomplete.c
> patching file ../bash-4.0/patchlevel.h
> build.pl :INFO: executing ==> cd
> /mnt/sdb8/sergei/AFSWD_debug/build/bash-4.0/../bash-4.0-patches;
> \patch -p0 < bash40-003
> patching file ../bash-4.0/parse.y
> patching file ../bash-4.0/patchlevel.h
> build.pl :INFO: executing ==> cd
> /mnt/sdb8/sergei/AFSWD_debug/build/bash-4.0/../bash-4.0-patches;
> \patch -p0 < bash40-004
> patching file ../bash-4.0/builtins/exit.def
> patching file ../bash-4.0/patchlevel.h
> build.pl :INFO: executing ==> cd
> /mnt/sdb8/sergei/AFSWD_debug/build/bash-4.0/../bash-4.0-patches;
> \patch -p0 < bash40-005
> patching file ../bash-4.0/builtins/declare.def
> patching file ../bash-4.0/patchlevel.h
> build.pl :INFO: executing ==> cd
> /mnt/sdb8/sergei/AFSWD_debug/build/bash-4.0/../bash-4.0-patches;
> \patch -p0 < bash40-006
> patching file ../bash-4.0/parse.y
> patching file ../bash-4.0/patchlevel.h
> build.pl :INFO: executing ==> cd
> /mnt/sdb8/sergei/AFSWD_debug/build/bash-4.0/../bash-4.0-patches;
> \patch -p0 < bash40-007
> patching file ../bash-4.0/parse.y
> patching file ../bash-4.0/arrayfunc.c
> patching file ../bash-4.0/subst.c
> patching file ../bash-4.0/patchlevel.h
> build.pl :INFO: executing ==> cd
> /mnt/sdb8/sergei/AFSWD_debug/build/bash-4.0/../bash-4.0-patches;
> \patch -p0 < bash40-008
> patching file ../bash-4.0/parse.y
> patching file ../bash-4.0/patchlevel.h
> build.pl :INFO: executing ==> cd
> /mnt/sdb8/sergei/AFSWD_debug/build/bash-4.0/../bash-4.0-patches;
> \patch -p0 < bash40-009
> patching file ../bash-4.0/builtins/read.def
> patching file ../bash-4.0/patchlevel.h
> build.pl :INFO: executing ==> cd
> /mnt/sdb8/sergei/AFSWD_debug/build/bash-4.0/../bash-4.0-patches;
> \patch -p0 < bash40-010
> patching file ../bash-4.0/parse.y
> patching file ../bash-4.0/patchlevel.h
> build.pl :INFO: executing ==> cd
> /mnt/sdb8/sergei/AFSWD_debug/build/bash-4.0/../bash-4.0-patches;
> \patch -p0 < bash40-011
> can't find file to patch at input line 21
> Perhaps you used the wrong -p or --strip option?
> The text leading up to this was:
> --------------------------
> |               
>             BASH PATCH REPORT
> |               
>             =================
> |
> |Bash-Release:  4.0
> |Patch-ID:      bash40-011
> |
> |Bug-Reported-by:       Matt Zyzik
> <Matt@ice.filescope.com>n
> |Bug-Reference-ID:      <20090312015018.C00741383ED@ice.filescope.com>
> |Bug-Reference-URL:     
> http://lists.gnu.org/archive/html/bug-bash/2009-03/msg00092.html
> |
> |Bug-Description:
> |
> |When using the new |& operator following a simple
> command with a redirection,
> |the redirection of stderr through the pipe was not
> performed under certain
> |circumstances.
> |
> |Patch:
> |
> |*** ../bash-4.0-patched/parse.y       
> 2009-03-08 21:24:47.000000000 -0400
> |--- parse.y    2009-03-12 21:36:23.000000000
> -0400
> --------------------------
> File to patch:
> Skip this patch? [y]
> Skipping patch.
> 1 out of 1 hunk ignored
> patching file ../bash-4.0/patchlevel.h
> ".
> 
> As one can see, patches before the one in question were
> cleanly applied.
> 
> Could you please fix it ?
> 
> Thanks,
>   Sergei.
> 
> 


Actually, _none_ of the patches after  bash40-010 can be applied - _all_
with the same problem because of wrong directory name or wrong directory.

This was _not_ the case with bash-3.2, and this not yet the case with
readline-6.0 - luckily.

It's a real pity - build process because of this can _not_ be automated,
just to skip these patches I was adding one by one these line of codes
after checking each failing patch:

"
                  next if $patch_file eq 'bash40-011'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-012'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-013'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-014'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-015'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-016'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-017'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-018'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-019'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-020'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-021'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-022'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-023'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-024'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-025'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-026'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-027'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-028'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-029'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-030'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-031'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-032'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-033'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-034'; # the patch is buggy - 
can't be applied cleanly
                  next if $patch_file eq 'bash40-035'; # the patch is buggy - 
can't be applied cleanly
".

I think _before_ a patch is accepted, it should be checked against
naming/directory conventions and it should be checked that _in_ _practice_
_all_ the patches can be applied in a uniform way.

Regards,
  Sergei.