[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Please remove iconv_open (charset, "ASCII"); from unicode.c

From: dethrophes
Subject: Re: Please remove iconv_open (charset, "ASCII"); from unicode.c
Date: Sat, 10 Mar 2012 22:49:57 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2

Am 10.03.2012 22:22, schrieb Chet Ramey:
On 3/6/12 11:47 PM, John Kearney wrote:
Hi chet can you please remove the following from the unicode.c file

localconv = iconv_open (charset, "ASCII");
Yeah, that was a typo.  It should be iconv_open ("ASCII", "UTF-8");
as originally in gnulib/coreutils.  Thanks for pointing it out; I
overlooked it.


Still pointless, though no longer dangerious :). save the overhead and just do a direct assignment, which is already done so just skip it altogether.

this is why in the last version I sent I had something like the following at the start of the function, instead of doing outside the function which makes it harder to keep track of what is actually going on.
if ( c <= 0x7f ){
  return 1;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]