Re: deadlock in waitchld()

[Chet Ramey]

On 6/12/13 3:00 AM, Roman Rakus wrote:
> On 05/24/13 16:00, Chet Ramey wrote:
>> On 5/24/13 9:30 AM, Roman Rakus wrote:
>>> The race is in do-while loop in wait_for(). At the start of wait_for() we
>>> are blocking SIGCHLD, however echo process ends during the loop and we
>>> don't register it (don't handle SIGCHLD, which is sent).
>>> Looking at the code, there is MUST_UNBLOCK_CHLD. May it make any harm to
>>> enable it by default?
>> I spent a lot of time looking at this yesterday, and I have it pretty much
>> fixed.  The problem is in the trap handling code, not wait_for().  The trap
>> problem ends up corrupting the jobs data structure, which is why wait_for
>> misbehaves.
>>
>> Chet
>>
> Hi Chet,
> Will be patch available somewhere? I checked devel branch on git. I would
> like to apply or backport a patch to older version.

I just pushed May's changes up to the devel branch.  Look at the changes
from 5/23.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU    chet@case.edu    http://cnswww.cns.cwru.edu/~chet/