Re: bash 4.3.11 on FreeBSD stable/{8, 9, 10}, and head, bug with backwards incremental search whenever horizontal-scroll-mode is on

[Trond Endrestøl]

On Mon, 21 Apr 2014 11:25+0200, Trond Endrestøl wrote:

> On Sun, 20 Apr 2014 22:29-0400, Chet Ramey wrote:
> 
> > On 4/19/14, 3:44 PM, Trond Endrestøl wrote:
> > > Hi,
> > > 
> > > I'm running GNU bash 4.3.11 on several branches of FreeBSD, more 
> > > specifically stable/{8,9,10}, and head (11.0-CURRENT), both 32-bit 
> > > (i386) and 64-bit (amd64).
> > > 
> > > Whenever horizontal-scroll-mode is set to on in .inputrc, backwards 
> > > incremental search fails to repaint the command line when doing 
> > > successive tappings on C-r. bash will misbehave even further when I 
> > > hit the enter key. More explanation follows.
> > 
> > Coincidentally, I've been looking at this problem for the last couple of
> > days, based on another report.  I've attached what I have so far, which
> > seems to fix the problem according to the testing I've done so far.  Let
> > me know how it works for you.
> 
> This patch looks very promising. I've so far only tested the patch on 
> a physical computer while logged in by mosh.
> 
> Hitting C-r, then typing "cvs" to lookup a command like 
> "cvs diff -u 2>&1", and hitting the enter key would previously display 
> "", but with the new patch in effect the whole command is displayed 
> when hitting the enter key.
> 
> I've compared this patch to 4.3.11 as installed on said computer, and 
> the patch does work for me.
> 
> I'd like to test the patch on a few of my FreeBSD VMs at home later 
> today. I'll keep you posted.

Sorry for the delay. I've just completed testing your patch with bash 
4.3.11 on FreeBSD stable/{8,9,10}, and head, and the patch does work.

I noticed during my testing with xterm 303 in X11, that even the 
unpatched bash 4.3.11 gets the redrawing right most of the time, but 
occasionally that version gets it wrong. I'd say commit the patch, 
unless you want to refine it further, it's a step in the right 
direction.

BTW, I took the liberty of attaching the output emitted by clang 3.4, 
the new system compiler in FreeBSD head and stable/10; it's optional 
in stable/9 and irrelevant in stable/8. The output contains harmless 
warnings.

I know it's hard to please every C compiler on every flavour of *nix, 
but maybe it's worth the extra work to iron out these warnings.

As a contrast, compiling bash with gcc 4.2.1 [FreeBSD patched] on 
stable/8, produced no warnings at all.

Have a nice day.


Trond.

-- 
----------------------------------------------------------------------
Trond Endrestøl                     |     Trond.Endrestol@ximalas.info
ACM, NAS, NUUG, SAGE, USENIX        |   FreeBSD 9.2-S & re-Alpine 2.03

make-in-shells-bash-without-colorized-clang-output.txt.gz
Description: make in shells/bash without colorized clang output