Re: [PATCH] build: fix build without MALLOC_STATS

[Eric Blake]

On 04/17/2015 11:46 AM, Chet Ramey wrote:
> On 4/17/15 10:47 AM, Eric Blake wrote:
>> gcc -L./builtins -L./lib/readline -L./lib/readline -L./lib/glob 
>> -L./lib/tilde -L./lib/malloc -L./lib/sh  -rdynamic  -g -O2 -Wno-parentheses 
>> -Wno-format-security -o bash shell.o eval.o y.tab.o general.o make_cmd.o 
>> print_cmd.o  dispose_cmd.o execute_cmd.o variables.o copy_cmd.o error.o 
>> expr.o flags.o jobs.o subst.o hashcmd.o hashlib.o mailcheck.o trap.o input.o 
>> unwind_prot.o pathexp.o sig.o test.o version.o alias.o array.o arrayfunc.o 
>> assoc.o braces.o bracecomp.o bashhist.o bashline.o  list.o stringlib.o 
>> locale.o findcmd.o redir.o pcomplete.o pcomplib.o syntax.o xmalloc.o  
>> -lbuiltins -lglob -lsh -lreadline -lhistory -ltermcap -ltilde -lmalloc    
>> -ldl
>> shell.o: In function `sh_exit':
>> /home/eblake/bash/shell.c:968: undefined reference to `trace_malloc_stats'
>>
>> * shell.c (sh_exit): Require MALLOC_STATS, not just MALLOC_DEBUG.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---
>>
>> Another fix that I need to get the devel branch of bash.git to compile
>> (I'm not sure what logic you intended for MALLOC_DEBUG vs.
>> MALLOC_STATS, nor if one should imply the other, so I'm okay if your
>> patch is different than my temporary workaround).
> 
> Look at lib/malloc/imalloc.h, where MALLOC_DEBUG implies MALLOC_STATS.

And again, I can't reproduce it from a fresh checkout, so it must be due
to some incremental garbage left behind from an earlier checkout,
coupled with incomplete 'make' dependency rules to force a rebuild when
whatever change to the headers caused a difference in the semantics of
the preprocessor conditionals.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature